Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-scripts to 5.0.0 #280

Merged
merged 3 commits into from
Dec 23, 2021
Merged

Bump react-scripts to 5.0.0 #280

merged 3 commits into from
Dec 23, 2021

Conversation

pankona
Copy link
Member

@pankona pankona commented Dec 21, 2021

Closes: #277

Updates

  • Fix eslint error caused by bumping react-scripts to 5.0.0

Remarks

dependabot bot and others added 2 commits December 20, 2021 09:23
Bumps [react-scripts](https://github.com/facebook/create-react-app/tree/HEAD/packages/react-scripts) from 4.0.3 to 5.0.0.
- [Release notes](https://github.com/facebook/create-react-app/releases)
- [Changelog](https://github.com/facebook/create-react-app/blob/main/CHANGELOG.md)
- [Commits](https://github.com/facebook/create-react-app/commits/react-scripts@5.0.0/packages/react-scripts)

---
updated-dependencies:
- dependency-name: react-scripts
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@pankona pankona requested a review from kachick December 21, 2021 05:52
@pankona
Copy link
Member Author

pankona commented Dec 21, 2021

@mobu-of-the-world/maintainers
Please review and merge if there's no concern! 😋

@@ -206,7 +206,7 @@ const numberToTimeString = (count: number): string => {
return elapsedTime.toISOString().substr(11, 8);
};

const shuffleArray = <T extends unknown>(array: T[]): T[] => {
const shuffleArray = <T,>(array: T[]): T[] => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮

Copy link
Member

@kachick kachick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@kachick
Copy link
Member

kachick commented Dec 22, 2021

yarn.lock in conflicting...

@pankona Could you update?

@pankona
Copy link
Member Author

pankona commented Dec 23, 2021

@kachick

Updated! please review & merge again! 😋

@pankona
Copy link
Member Author

pankona commented Dec 23, 2021

@kachick

Oh, sorry, you already give approve!
I'll go for merge. Thanks! 😋

@pankona pankona merged commit 359fa2d into main Dec 23, 2021
@pankona pankona deleted the bump-react-scripts-5.0.0 branch December 23, 2021 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants